The following markers were found:
  • todo  13

Amfphp\Core\Amf\Handler.php4

Type Line Description
todo 13 determine if indirection for serializer/deserializer necessary. Makes gateway code lighter, but is cumbersome
todo 21 consider an interface for $handler. Maybe overkill here
todo 32 consider an interface for $handler. Maybe overkill here
todo 41 consider an interface for $handler. Maybe overkill here

Amfphp\Core\Amf\Serializer.php2

Type Line Description
todo 474 no type markers ("\6', for example) in this method!
todo 598 it would seem that to create only one traits entry for an anonymous object would be the way to go. this however messes things up in both Flash and Charles Proxy. For testing call discovery service using AMF. investigate.

Amfphp\Core\Common\ServiceRouter.php1

Type Line Description
todo 60 maybe option for a fully qualified class name. this method is static so that it can be used also by the discovery service '__' are replaced by '/' to help the client generator support packages without messing with folders and the like

Amfphp\Core\Gateway.php1

Type Line Description
todo 34 this filter only allows manipulation of raw post data, and is as such a bit misleading. Maybe rename and do filters for GET and POST

Amfphp\Plugins\AmfphpErrorHandler\AmfphpErrorHandler.php1

Type Line Description
todo 12 this could be enhanced to use filters so that at the end of the gateway execution the error handling is set back to normal. This could be useful especially for integration with frameworks.

BackOffice\ServiceBrowser.php1

Type Line Description
todo 41 reunderstand and comment this objname thing...

Tests\Amfphp\Core\Amf\DeserializationTest.php1

Type Line Description
todo 116 better tests for references

Tests\TestData\Amf3TestData.php1

Type Line Description
todo 284 methods with a type marker included

Tests\TestData\AmfTestData.php1

Type Line Description
todo 583 the spec says count of all sub objects(here 2) , whereas the code says count of objects with numerical keys(here 1). Clean? A.S.